Conversation
In #24156 we removed a lot of unnecessary calls to user.Current, which can take a long time in Active Directory environments. This commit removes a few other uses of user.Current where we were doing a full user lookup only to find the user's home directory, which is usually more readily available via the environment.
r0mant
approved these changes
May 9, 2023
Joerger
approved these changes
May 9, 2023
public-teleport-github-review-bot
Bot
removed request for
capnspacehook and
fspmarshall
This was referenced May 10, 2023
zmb3
added a commit
that referenced
this pull request
May 10, 2023
This fixes a bug introduced in #25950
Merged
zmb3
added a commit
that referenced
this pull request
May 10, 2023
This fixes a bug introduced in #25950
zmb3
added a commit
that referenced
this pull request
May 11, 2023
This fixes a bug introduced in #25950
zmb3
added a commit
that referenced
this pull request
May 11, 2023
This fixes a bug introduced in #25950
zmb3
added a commit
that referenced
this pull request
May 11, 2023
* User os.UserHomeDir where possible In #24156 we removed a lot of unnecessary calls to user.Current, which can take a long time in Active Directory environments. This commit removes a few other uses of user.Current where we were doing a full user lookup only to find the user's home directory, which is usually more readily available via the environment. * Fix tsh profile dir This fixes a bug introduced in #25950
michellescripts
pushed a commit
that referenced
this pull request
May 11, 2023
* User os.UserHomeDir where possible In #24156 we removed a lot of unnecessary calls to user.Current, which can take a long time in Active Directory environments. This commit removes a few other uses of user.Current where we were doing a full user lookup only to find the user's home directory, which is usually more readily available via the environment. * Fix tsh profile dir This fixes a bug introduced in #25950
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #24156 we removed a lot of unnecessary calls to user.Current, which can take a long time in Active Directory environments.
This commit removes a few other uses of user.Current where we were doing a full user lookup only to find the user's home directory, which is usually more readily available via the environment.
Updates #25014